Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common manifest shared between GKE and EKS guides #1467

Closed
Tracked by #1578
rzetelskik opened this issue Oct 11, 2023 · 4 comments
Closed
Tracked by #1578

Use a common manifest shared between GKE and EKS guides #1467

rzetelskik opened this issue Oct 11, 2023 · 4 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rzetelskik
Copy link
Member

Our docs currently have dedicated examples for EKS and GKE guides. The reason for this is historical and now, as far as I know, there are no reasons against having a common manifest shared between the two guides, other than the topology keys potentially differing between the two. We should therefore have a single manifest shared between the two. It would be simpler to maintain in the long run.

/kind documentation
@scylla-operator-bot scylla-operator-bot bot added kind/documentation Categorizes issue or PR as related to documentation. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 11, 2023
@tnozicka
Copy link
Member

I think most importantly docs should have the manifests inlined so people don't have to checkout the repo at all.

@rzetelskik rzetelskik added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2023
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2024
@tnozicka
Copy link
Member

tnozicka commented Jul 1, 2024

/remove-lifecycle stale
/triage accepted

@scylla-operator-bot scylla-operator-bot bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 1, 2024
@rzetelskik rzetelskik mentioned this issue Oct 21, 2024
Closed
@tnozicka
Copy link
Member

Fixed in #2188

@tnozicka tnozicka mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnozicka @rzetelskik