Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements in documentation #2080

Open
11 tasks
grzywin opened this issue Aug 16, 2024 · 4 comments
Open
11 tasks

Minor improvements in documentation #2080

grzywin opened this issue Aug 16, 2024 · 4 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@grzywin
Copy link

grzywin commented Aug 16, 2024

What should the feature do?

As someone relatively new to Kubernetes and Operator, I was attempting to configure a cluster using the instructions provided in the official Operator documentation. During this process, I encountered some minor issues and inconsistencies.

https://operator.docs.scylladb.com/stable/generic.html

  • In the prerequisites, it mentions "A Storage Class to provision PersistentVolumes." Why not include steps to create a Storage Class (SC) and Persistent Volume (PV) in the documentation, as already done here with the local CSI driver and XFS volume?
  • Helm 3 is listed as a prerequisite, but it’s not used anywhere on the generic.html page. Why is it included?
  • The example output of the command kubectl -n scylla get pods shows that each Scylla pod should have 2/2 containers ready, but in reality, it’s 3/3 (manager agent, Scylla, and Scylla operator).
  • Is the "Configure host networking" section outdated?
  • Connecting to the cluster using the Python Cassandra driver doesn't work as straightforwardly as suggested by the instructions. Why not include information on NodePort configuration or a simple example of the port-forwarding command?
  • The --dry-run command was deprecated and should be replaced with --dry-run=client in the command: kubectl create configmap scylla-config -n scylla --from-file=/tmp/scylla.yaml --from-file=/tmp/cassandra-rackdc.properties -o yaml --dry-run | kubectl replace -f -.
  • In the "Benchmark with cassandra-stress" section, the commands kubectl apply -f scripts/cassandra-stress.yaml and kubectl delete -f scripts/cassandra-stress.yaml refer to a file located in the hack folder. The correct command should be -f hack/cassandra-stress.yaml.

https://operator.docs.scylladb.com/stable/monitoring.html

  • The $ sign could be removed from some commands in the monitoring section, as it’s done in generic.html, to allow users to easily copy and paste the command content.
  • The Scylla namespace (-n scylla) is missing from the commands in the "Waiting for ScyllaDBMonitoring to roll out," "Waiting for Prometheus to roll out," and "Waiting for Grafana to roll out" sections. The Scylla namespace is provided everywhere else.
  • In the ScyllaDBMonitoring manifest, there is a line 'scylla/cluster: replace-with-your-scyllacluster-name'. Since most newcomers will work with default values, why not replace it with 'scylla/cluster: simple-cluster # replace-with-your-scyllacluster-name'?
  • As a rookie, I struggled to connect to Grafana by following the instructions in the "Accessing Grafana" chapter. Why not add a way to connect to Grafana through a web browser, either by using NodePort or by executing the port-forward command?

Most of these points are trivial, and if there are plans to rewrite the documentation, they can probably be discarded. However, I believe it’s important to acknowledge what might challenge newcomers.

What is the use case behind this feature?

Improve user experience.

Anything else we need to know?

No response

@grzywin grzywin added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 16, 2024
@tnozicka tnozicka added kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 16, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 16, 2024
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@tnozicka tnozicka removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2024
@tnozicka
Copy link
Member

/remove-lifecycle stale

@scylla-operator-bot scylla-operator-bot bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2024
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024
@tnozicka tnozicka added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants