From 43e422189dac04fa202015191a7eca76e1df2bf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis=20Pr=C3=A9?= Date: Wed, 24 Jul 2024 10:42:46 -0700 Subject: [PATCH] chore: Fix some types --- .../components/AccessCodeDetails/AccessCodeDetails.tsx | 2 +- .../seam/components/AccessCodeTable/AccessCodeMenu.tsx | 9 ++++++--- .../seam/components/AccessCodeTable/AccessCodeTable.tsx | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx b/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx index f0f6ea150..fb5c725d5 100644 --- a/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx +++ b/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx @@ -27,7 +27,7 @@ import { useIsDateInPast } from 'lib/ui/use-is-date-in-past.js' export interface AccessCodeDetailsProps extends CommonProps { accessCodeId: string onEdit: () => void - onDelete: () => void + onDelete?: () => void isBeingRemoved?: boolean } diff --git a/src/lib/seam/components/AccessCodeTable/AccessCodeMenu.tsx b/src/lib/seam/components/AccessCodeTable/AccessCodeMenu.tsx index 4d32d7a27..b4fa627cf 100644 --- a/src/lib/seam/components/AccessCodeTable/AccessCodeMenu.tsx +++ b/src/lib/seam/components/AccessCodeTable/AccessCodeMenu.tsx @@ -15,8 +15,6 @@ export interface AccessCodeMenuProps { onViewDetails: () => void disableEditAccessCode: boolean disableDeleteAccessCode: boolean - deleteConfirmationVisible: boolean - toggleDeleteConfirmation: () => void } export function AccessCodeMenu(props: AccessCodeMenuProps): JSX.Element { @@ -44,6 +42,11 @@ export function AccessCodeMenu(props: AccessCodeMenuProps): JSX.Element { ) } +interface ContentProps extends AccessCodeMenuProps { + deleteConfirmationVisible: boolean + toggleDeleteConfirmation: () => void +} + function Content({ accessCode, onViewDetails, @@ -53,7 +56,7 @@ function Content({ onDelete, deleteConfirmationVisible, toggleDeleteConfirmation, -}: AccessCodeMenuProps): JSX.Element { +}: ContentProps): JSX.Element { const deleteAccessCode = useDeleteAccessCode() if (deleteConfirmationVisible) { diff --git a/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx b/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx index 0a9abc413..8cae27d0b 100644 --- a/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx +++ b/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx @@ -105,7 +105,7 @@ export function AccessCodeTable({ ?.filter((accessCode) => accessCodeFilter(accessCode, searchInputValue)) ?.map((accessCode) => deletedAccessCodeIds.includes(accessCode.access_code_id) - ? { ...accessCode, status: 'removing' } + ? { ...accessCode, status: 'removing' as const } : accessCode ) ?.sort(accessCodeComparator) ?? [],