Replies: 6 comments
-
I initally also spent some time evaluating JavaRule which is done according to JSR223, but I could not figure a way (back then) to build my rules in IntelliJ and deploy them as a compiled jar file. I neither got a clear picture of how to write unit tests. To me a web editor has very little value. One thing I do miss is the ability to
I started to fiddle with this a few weeks back, but other priorities took over. Pushed the code at #90 but I only got so far that I could register a single hardcoded rule. |
Beta Was this translation helpful? Give feedback.
-
I never used the feature to see all my rules in the main-ui. (The ui crashes the browser every time, since over a year) |
Beta Was this translation helpful? Give feedback.
-
Nice to see that we sort of agree. PR 90 looks nice, yes would be nice to be able to enable / disable rules in the ui. |
Beta Was this translation helpful? Give feedback.
-
Will there be no option to get JRule officially into openHAB because of that? |
Beta Was this translation helpful? Give feedback.
-
IMHO I personally have no goal of trying to get it into the official distro. I've done it twice, and it is an extremely lengthy and time consuming task. I'd rather spend time improving the marketplace functionality to make unofficial releases easier and more visible to the user. However, this is up @seaside1 to pursue if he wishes :) |
Beta Was this translation helpful? Give feedback.
-
I'm not sure. Seems like rules languages in general are a bit sensitive in openHAB. I don't think they would want to merge unless we are JSR compliant. It might also be more difficult to maintain and do changes since the maintainers would take decisions on what to merge. On the other hand JRule might mature and we might feel like we don't have that much to add, or do big refactorings, then we might try. |
Beta Was this translation helpful? Give feedback.
-
I have looked into this previously. It should be possible to make JRule compatible with JSR223.
However now looking into the core classes (RuleRegistry, ScriptedAutomationManager, SimpleRule and some others).
I can see that it seems we would end up loosing a lot of control on how the rules are executed, and possibly also some of the conditions, which might miss some of the stuff we are using.
So my question is more if we think it's worth pursuing JSR223 compatibility or not? One advantage would be that you could use the Openhab GUI to view loaded and active rules, as well as making simple modifications and testing in openHAB GUI.
Personally I don't use the openHAB GUI and can live without it but would like to hear more opinions on the matter.
Beta Was this translation helpful? Give feedback.
All reactions