Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for all rule actions #82

Open
seime opened this issue Nov 6, 2022 · 7 comments · May be fixed by #204
Open

Feature request: Add support for all rule actions #82

seime opened this issue Nov 6, 2022 · 7 comments · May be fixed by #204

Comments

@seime
Copy link
Collaborator

seime commented Nov 6, 2022

Currently we have support for thing actions which is great.

But I'd also love to see support for other actions like the openhab cloud sendNotification action.

Could be generated code just like ThingActions today.

WDYT @querdenker2k ?

@querdenker2k
Copy link
Collaborator

Shouldn't this be already generated within JRuleActions?

@seime
Copy link
Collaborator Author

seime commented Nov 6, 2022

All my generated actions are ThingActions, but I am talking about the more generic "module" actions. They are at least not available in the generated code on my side.

@querdenker2k
Copy link
Collaborator

I never used this, thought these are actions from the myopenhab binding.
From the current concept, should this be just added to JRule?

@seime
Copy link
Collaborator Author

seime commented Nov 7, 2022

I guess it boils down to which addons that a user has installed, so I believe we need to generate this as well.

@querdenker2k
Copy link
Collaborator

I think this is contained in the openhab "core", because it's documented here: https://www.openhab.org/docs/configuration/actions.html#cloud-notification-actions

@querdenker2k
Copy link
Collaborator

Yes, you're right. So it makes sense to generate this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants