more cleanup

secure-software-engineering · Oct 21, 2024 · 844b1ff · 844b1ff
1 parent 5ebf858
commit 844b1ff
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 17 deletions.
diff --git a/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h b/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h
@@ -38,7 +38,7 @@ class FlowEdgeFunctionCacheNG
   void reserve(size_t NumInsts, size_t NumCalls, size_t NumFuns) {
     this->FlowFunctionCache<ProblemTy, AutoAddZero>::reserve(NumInsts, NumCalls,
                                                              NumFuns);
-    /// TODO: reserve edge functions as well!
+    /// XXX: reserve edge functions as well, once possible!
   }
 
   [[nodiscard]] FlowEdgeFunctionCacheStats getStats() const noexcept {

diff --git a/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h b/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h
@@ -299,12 +299,6 @@ class FlowFunctionCache
     /// XXX: The old FECache doesn't cache summary FFs, so refrain from doing
     /// this here as well. Enable it, once the user-problems reliably return
     /// std::nullptr_t such that caching can be disabled automatically
-
-    // return getFlowFunction<summary_ff_t>(
-    //     SummaryFFCache, CSCalleeId, Problem,
-    //     [CallSite, Callee](ProblemTy &Problem) {
-    //       return Problem.getSummaryFlowFunction(CallSite, Callee);
-    //     });
   }
 
   void clear() noexcept {

diff --git a/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h b/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h
@@ -10,8 +10,6 @@
  *     Fabian Schiebel
  *****************************************************************************/
 
-#include "phasar/DataFlow/IfdsIde/EdgeFunctions.h"
-#include "phasar/DataFlow/IfdsIde/IDETabulationProblem.h"
 #include "phasar/DataFlow/IfdsIde/IFDSTabulationProblem.h"
 #include "phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h"
 #include "phasar/DataFlow/IfdsIde/Solver/WorkListTraits.h"
@@ -101,14 +99,6 @@ using IFDSSolverConfigWithStatsAndGC =
 
 template <typename ProblemTy, typename Enable = void>
 struct DefaultIDESolverConfig : IDESolverConfig {};
-// template <typename ProblemTy>
-// struct DefaultIDESolverConfig<
-//     ProblemTy,
-//     std::enable_if_t<std::is_base_of_v<
-//         IFDSTabulationProblemLight<
-//             typename ProblemTy::ProblemAnalysisDomain::BaseAnalysisDomain,
-//             ProblemTy>,
-//         ProblemTy>>> : IFDSSolverConfig {};
 
 template <typename ProblemTy>
 struct DefaultIDESolverConfig<