From 844b1ffef62cd833c2a508dbe0de3b99fbf5b2c4 Mon Sep 17 00:00:00 2001 From: Fabian Schiebel Date: Mon, 21 Oct 2024 19:26:52 +0200 Subject: [PATCH] more cleanup --- .../DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h | 2 +- .../phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h | 6 ------ .../DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h | 10 ---------- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h b/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h index 0a5ef33dd..3206ef7b2 100644 --- a/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h +++ b/include/phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h @@ -38,7 +38,7 @@ class FlowEdgeFunctionCacheNG void reserve(size_t NumInsts, size_t NumCalls, size_t NumFuns) { this->FlowFunctionCache::reserve(NumInsts, NumCalls, NumFuns); - /// TODO: reserve edge functions as well! + /// XXX: reserve edge functions as well, once possible! } [[nodiscard]] FlowEdgeFunctionCacheStats getStats() const noexcept { diff --git a/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h b/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h index ac0d9c2c2..b5eddc168 100644 --- a/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h +++ b/include/phasar/DataFlow/IfdsIde/Solver/FlowFunctionCache.h @@ -299,12 +299,6 @@ class FlowFunctionCache /// XXX: The old FECache doesn't cache summary FFs, so refrain from doing /// this here as well. Enable it, once the user-problems reliably return /// std::nullptr_t such that caching can be disabled automatically - - // return getFlowFunction( - // SummaryFFCache, CSCalleeId, Problem, - // [CallSite, Callee](ProblemTy &Problem) { - // return Problem.getSummaryFlowFunction(CallSite, Callee); - // }); } void clear() noexcept { diff --git a/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h b/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h index 6fbfd8bfd..758a06248 100644 --- a/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h +++ b/include/phasar/DataFlow/IfdsIde/Solver/StaticIDESolverConfig.h @@ -10,8 +10,6 @@ * Fabian Schiebel *****************************************************************************/ -#include "phasar/DataFlow/IfdsIde/EdgeFunctions.h" -#include "phasar/DataFlow/IfdsIde/IDETabulationProblem.h" #include "phasar/DataFlow/IfdsIde/IFDSTabulationProblem.h" #include "phasar/DataFlow/IfdsIde/Solver/FlowEdgeFunctionCacheNG.h" #include "phasar/DataFlow/IfdsIde/Solver/WorkListTraits.h" @@ -101,14 +99,6 @@ using IFDSSolverConfigWithStatsAndGC = template struct DefaultIDESolverConfig : IDESolverConfig {}; -// template -// struct DefaultIDESolverConfig< -// ProblemTy, -// std::enable_if_t, -// ProblemTy>>> : IFDSSolverConfig {}; template struct DefaultIDESolverConfig<