fix global handling in type state analysis

secure-software-engineering · Aug 2, 2023 · ac973ce · ac973ce
1 parent f1c5865
commit ac973ce
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDETypeStateAnalysis.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDETypeStateAnalysis.cpp
@@ -359,6 +359,11 @@ IDETypeStateAnalysis::getRetFlowFunction(
           RelAllocas.insert(Allocas.begin(), Allocas.end());
         }
         Res.insert(RelAllocas.begin(), RelAllocas.end());
+        if (llvm::isa<llvm::Constant>(Source)) {
+          const auto &SourceAndAliases =
+              Analysis->getWMAliasesAndAllocas(Source);
+          Res.insert(SourceAndAliases.begin(), SourceAndAliases.end());
+        };
         return Res;
       }
       return {Source};
@@ -414,6 +419,8 @@ IDETypeStateAnalysis::getCallToRetFlowFunction(
           return killManyFlows<d_t>(getWMAliasesAndAllocas(Arg.get()));
         }
       }
+      return killFlowIf<d_t>(
+          [](d_t Source) { return llvm::isa<llvm::Constant>(Source); });
     }
   }
   return Identity<IDETypeStateAnalysis::d_t>::getInstance();