Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more link-types in packet parsing #1612

Open
dromniscience opened this issue Oct 9, 2024 · 2 comments
Open

Support more link-types in packet parsing #1612

dromniscience opened this issue Oct 9, 2024 · 2 comments
Labels

Comments

@dromniscience
Copy link

dromniscience commented Oct 9, 2024

Question

Hi, when I used pcpp (v24.09) to parse a RawPacket read from a CAIDA trace of link-type C_HDLC (Cisco HDLC), it failed to get any layer but recognized the whole packet as payload. Will pcpp add support for link-type C_HDLC and even more to packet parsing in the future?

I think the reason lies in the function Layer* Packet::createFirstLayer(LinkLayerType linkType) that is invoked when parsing a RawPacket. It only recognizes LINKTYPE_ETHERNET, LINKTYPE_LINUX_SLL, LINKTYPE_LINUX_SLL2, LINKTYPE_NULL, LINKTYPE_RAW, LINKTYPE_DLT_RAW1, LINKTYPE_DLT_RAW2, LINKTYPE_IPV4, LINKTYPE_IPV6, LINKTYPE_NFLOG so far. Besides, the current document does not seem to mention supported link types in packet parsing (or not in a obvious place).

Operating systems

Linux

@seladb
Copy link
Owner

seladb commented Oct 9, 2024

@dromniscience Cisco HDLC is not currently supported, but maybe you can consider adding support for it?

@dromniscience
Copy link
Author

@seladb Sure, I'll do it in my spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants