RawPacket::copyDataFrom will have a memory-leak if instance owns its m_RawData, otherwise the length might not match

[Elgu]

PcapPlusPlus/Packet++/src/RawPacket.cpp

Line 76 in 35f486c

void RawPacket::copyDataFrom(const RawPacket& other, bool allocateData)

There are actually two issues:

1. If allocateData is set, m_RawData is overwritten without checking if delete[] has to be called first
2. If allocateData is not set, the data from other is memcpied without checking whether m_RawData points to a buffer of sufficient size

[seladb]

RawPacket::copyDataFrom() is a private method that is not exposed to the user. It expects the caller to perform these checks. The only relevant place is operator= which calls it with allocateData=true, but it deletes the data first.