From 2457cbc13e0b8e6eaeaf9e5d1aec33d6984c284c Mon Sep 17 00:00:00 2001 From: fiftin Date: Sun, 24 Mar 2024 23:08:23 +0100 Subject: [PATCH] test(login): claim | which always false --- api/login.go | 4 ++++ api/login_test.go | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/api/login.go b/api/login.go index 839b01210..b7e740207 100644 --- a/api/login.go +++ b/api/login.go @@ -431,6 +431,10 @@ func parseClaim(str string, claims map[string]interface{}) (string, bool) { for _, s := range strings.Split(str, "|") { s = strings.TrimSpace(s) + if s == "" { + continue + } + if strings.Contains(s, "{{") { tpl, err := template.New("").Parse(s) diff --git a/api/login_test.go b/api/login_test.go index ba501e473..95256dd47 100644 --- a/api/login_test.go +++ b/api/login_test.go @@ -53,3 +53,17 @@ func TestParseClaim3(t *testing.T) { t.Fail() } } + +func TestParseClaim4(t *testing.T) { + claims := map[string]interface{}{ + "username": "fiftin", + "email": "", + "id": 1234567, + } + + _, ok := parseClaim("|", claims) + + if ok { + t.Fail() + } +}