Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve this binding issues #209

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: resolve this binding issues #209

merged 2 commits into from
Oct 28, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Oct 28, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

  • Fixing the bug that prevents adding and removing reactions.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 11.57%. Comparing base (9547065) to head (079a363).

Files with missing lines Patch % Lines
...onents/ReactionAddons/BottomSheetReactionAddon.tsx 0.00% 2 Missing ⚠️
...s/ReactionBottomSheets/ReactionListBottomSheet.tsx 0.00% 2 Missing ⚠️
...react-native/src/hooks/usePushTokenRegistration.ts 0.00% 2 Missing ⚠️
...react-native/src/components/ChannelInput/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   11.57%   11.57%   -0.01%     
==========================================
  Files         356      356              
  Lines        8386     8390       +4     
  Branches     2341     2202     -139     
==========================================
  Hits          971      971              
- Misses       7339     7418      +79     
+ Partials       76        1      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 requested a review from OnestarLee October 28, 2024 04:17
Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit b0ad96b Oct 28, 2024
7 checks passed
@bang9 bang9 deleted the fix/this-binding-issues branch October 28, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants