Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-5553] fix: ensure image visibility in file viewer on new architecture #210

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Oct 28, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-5553

Description Of Changes

Due to the z-index, this problem occurs only in the New architecture.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.57%. Comparing base (b0ad96b) to head (ec6834b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   11.57%   11.57%           
=======================================
  Files         356      356           
  Lines        8390     8390           
  Branches     2341     2341           
=======================================
  Hits          971      971           
  Misses       7343     7343           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 requested a review from OnestarLee October 28, 2024 08:55
Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d1ddb87 Oct 29, 2024
7 checks passed
@bang9 bang9 deleted the fix/new-arch/file-viewer branch October 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants