Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-5902] feat: added showUserId config to suggested mention list #220

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 28, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-5902

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 requested a review from OnestarLee November 28, 2024 08:07
@bang9 bang9 self-assigned this Nov 28, 2024
@bang9 bang9 changed the title feat: added showUserId config to suggested mention list [CLNP-5902] feat: added showUserId config to suggested mention list Nov 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 11.52%. Comparing base (b021c59) to head (5f7c6af).

Files with missing lines Patch % Lines
...nel/component/GroupChannelSuggestedMentionList.tsx 0.00% 3 Missing ⚠️
...mponent/GroupChannelThreadSuggestedMentionList.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   11.53%   11.52%   -0.01%     
==========================================
  Files         357      357              
  Lines        8459     8465       +6     
  Branches     2360     2385      +25     
==========================================
  Hits          976      976              
+ Misses       7482     7414      -68     
- Partials        1       75      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit f229033 Nov 28, 2024
7 checks passed
@bang9 bang9 deleted the feat/mention-list-showUserId branch November 28, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants