Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: throughly document DataTypes (v6) #311

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

docs: throughly document DataTypes (v6) #311

wants to merge 7 commits into from

Conversation

fzn0x
Copy link
Member

@fzn0x fzn0x commented Oct 15, 2022 •
edited
Loading

Improve the example datatypes TEXT, makes the documentation beginner-friendly as much as possible.

Follow-Up Tasks

  • Added more helpful content for datatypes that only show description in Sequelize API reference (v6).

@github-actions
Copy link

Logs: https://app.netlify.com/sites/sequelize-site/deploys/634ad3397661544088c0da4b
Website Draft URL: https://634ad3397661544088c0da4b--sequelize-site.netlify.app

@fzn0x fzn0x requested review from WikiRik and sdepold October 15, 2022 15:37
@github-actions
Copy link

Logs: https://app.netlify.com/sites/sequelize-site/deploys/634ad52547ed833ce5df09c6
Website Draft URL: https://634ad52547ed833ce5df09c6--sequelize-site.netlify.app

@WikiRik
Copy link
Member

WikiRik commented Oct 17, 2022

Let's refer to https://github.com/sequelize/website/blob/main/docs/other-topics/other-data-types.mdx in v7
For v6 I think we could do the same, but we should update that page first (see #11 for that)

@fzn0x
Copy link
Member Author

fzn0x commented Oct 24, 2022

Let's refer to https://github.com/sequelize/website/blob/main/docs/other-topics/other-data-types.mdx in v7 For v6 I think we could do the same, but we should update that page first (see #11 for that)

Thank you! will start working on this

@fzn0x fzn0x changed the title docs: improve example for datatypes TEXT docs: throughly document DataTypes (v6) Oct 26, 2022
@fzn0x
Copy link
Member Author

fzn0x commented Oct 26, 2022

Hi bro @WikiRik I added the requested changes. Need help to review it before merging :)

cc @ephys

@fzn0x
Copy link
Member Author

fzn0x commented Oct 26, 2022

Added follow up tasks in PR description

@github-actions
Copy link

Logs: https://app.netlify.com/sites/sequelize-site/deploys/635913f14f1f48146c4e8305
Website Draft URL: https://635913f14f1f48146c4e8305--sequelize-site.netlify.app

@fzn0x fzn0x requested a review from ephys October 26, 2022 11:11
@github-actions
Copy link

Logs: https://app.netlify.com/sites/sequelize-site/deploys/6359162fde2639169767b366
Website Draft URL: https://6359162fde2639169767b366--sequelize-site.netlify.app

@sequelize-bot sequelize-bot bot added the conflicted This PR has merge conflicts and will not be present in the list of PRs to review label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik Awaiting requested review from WikiRik

@sdepold sdepold Awaiting requested review from sdepold

@ephys ephys Awaiting requested review from ephys

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conflicted This PR has merge conflicts and will not be present in the list of PRs to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzn0x @WikiRik