Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/migrate to phoenix liveview 0.18.11 #50

Merged
merged 20 commits into from
Jan 23, 2023

Conversation

sgobotta
Copy link
Owner

@sgobotta sgobotta commented Jan 23, 2023


name: Pull Request
about: Phoenix Liveview 0.18.11 migration
title: ''
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • ⬆️ Migrate to phoenix liveview 0.18.11
  • 🎨 Minor style improvements in the fiel upload inputs
  • 💻 Fix a few rendering bugs and heroicon names
  • 💻 Fix warnings on rendered components
  • 💻 Fixes a heroicon
  • 💻 Remove image extensions from live reload patterns
  • 💻 Remove unused conditional
  • 💻 Improve modal close button
  • 💻 Update action buttons
  • 🔧 Add @apply rule to config
  • 💻 Migrate to Elixir 1.14.3
  • 🎨 Fix duped values
  • 💻 Update some layout values
  • 💻 Remove unused code
  • 💻 Update shop icons
  • ⬆️ Upgrade to Erlang 25.2.1
  • 💻 Icons update

Fixes #49

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta added the enhancement New feature or request label Jan 23, 2023
@sgobotta sgobotta self-assigned this Jan 23, 2023
@sgobotta sgobotta merged commit 4e2aaba into dev Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix avatar and banner uploads for the shop liveview
1 participant