Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make torrequest optional #2215

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Make torrequest optional #2215

merged 3 commits into from
Jul 8, 2024

Conversation

ppfeister
Copy link
Member

Closes #2130

Sample interaction without dependency:

$ sherlock --tor test
Using Tor to make requests
Warning: some websites might refuse connecting over Tor, so note that using this option might increase connection errors.
[*] Checking username test on:

Important!
> Dependencies for --tor and --unique-tor are now optional, and WILL BE DEPRECATED in a future release of Sherlock.
> If you've installed Sherlock via pipx, you can install the dependency with `pipx install sherlock-project[tor]`.
> Other packages should refer to their packager maintainer's documentation, or install separately with `pipx install torrequest`.

[*] Search completed with 0 results

@ppfeister ppfeister added the staged - do not merge PR is staged for coordinated release label Jul 1, 2024
@ppfeister
Copy link
Member Author

Not 100% on this one, may need another look

Copy link
Member

@sdushantha sdushantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I doubt many people will notice this as I doubt may use --tor, but that's just an assumption

@ppfeister ppfeister merged commit 27badf6 into master Jul 8, 2024
16 checks passed
@ppfeister ppfeister deleted the 2130-torrequest branch July 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged - do not merge PR is staged for coordinated release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make torrequest (and other deps) optional
2 participants