Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger progress, confirm, prompt, etc. output not captured in log files #2147

Closed
bryanoltman opened this issue May 24, 2024 · 4 comments · Fixed by #2170
Closed

fix: logger progress, confirm, prompt, etc. output not captured in log files #2147

bryanoltman opened this issue May 24, 2024 · 4 comments · Fixed by #2170
Labels
bug Something isn't working

Comments

@bryanoltman
Copy link
Contributor

ShorebirdLogger writes info, detail, error, etc to a log file, but output from prompts, confirms, progress, etc. are not captured. The logs would be more helpful if they were an exact copy of what the user sees when running a command with the -v flag.

@bryanoltman bryanoltman added the bug Something isn't working label May 24, 2024
@bryanoltman
Copy link
Contributor Author

It's possible adding a stdout/stderr hook to mason_logger might be the solution here? @felangel wdyt?

@erickzanardo
Copy link
Contributor

Or maybe mason_logger could support mirroring its output to a file? That would remove the need of ShorebirdLogger to even existing.

@felangel
Copy link
Contributor

Or maybe mason_logger could support mirroring its output to a file? That would remove the need of ShorebirdLogger to even existing.

Yeah that’s an interesting idea. Feel free to throw up an issue/proposal on mason 👍

@erickzanardo
Copy link
Contributor

Yeah that’s an interesting idea. Feel free to throw up an issue/proposal on mason 👍

Done: felangel/mason#1338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants