chore!: Update rust_eth_kzg to v0.5.1 (formally known as peerdas-kzg) #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu>
Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu>
Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu>
kevaundray
commented
Aug 27, 2024
kevaundray
commented
Aug 27, 2024
kevaundray
commented
Aug 27, 2024
kevaundray
changed the title
kevaundray
added a commit
to kevaundray/lighthouse
that referenced
this pull request
Aug 27, 2024
jimmygchen
reviewed
Aug 28, 2024
jimmygchen
approved these changes
Aug 28, 2024
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5e9cc60 |
This was referenced Aug 28, 2024
Merged
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
…sigp#6309) * update rust_eth_kzg Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu> * Update kzg module Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu> * update benchmark code Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu> * Add note on trusted setup configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
v0.5.0 was published with the following changes: crate-crypto/rust-eth-kzg#161
From the list of breaking changes in that link, the ones relevant to downstream rust users are:
Which issue # does this PR address?
Proposed Changes
recover_cells_and_kzg_proofsAdditional Info
Rayon's global threadpool and local threadpool seems to have issues -- if we were to enable multithreading it would be using the global threadpool.
In a future PR, I think we would want to re-enable multithreading as we are experimenting with a branch which allows us to parallelize across blobs. As a corollary, it reduces the precomputation by 50x and is faster on a single thread (the speedup numbers are still being looked into, currently it seems to be ~20%)