Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verifying detached SCTs #315

Closed
cmurphy opened this issue Oct 16, 2024 · 2 comments
Closed

Support verifying detached SCTs #315

cmurphy opened this issue Oct 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cmurphy
Copy link
Contributor

cmurphy commented Oct 16, 2024

Description

Currently sigstore-go assumes that an SCT is embedded in a leaf certificate:

scts, err := x509util.ParseSCTsFromCertificate(leafCert.Raw)

Fulcio may return either an embedded SCT or a detached SCT in a response header:

https://github.com/sigstore/fulcio/blob/main/docs/ctlog.md#signed-certificate-timestamp-sct

Cosign supports both cases. In order to enable integration of sigstore-go's SCT verification into cosign, which would allow cosign to reuse sigstore-go's excellent TUF trusted root support (described here), it would be nice if sigstore-go provided a way to supply an SCT alongside, rather than embedded in, a certificate.

@cmurphy cmurphy added the enhancement New feature or request label Oct 16, 2024
@haydentherapper
Copy link
Contributor

We plan to deprecate support for detached SCTs - sigstore/fulcio#1499

The reason is that we have no way to store SCTs currently, so detached SCTs are only checked during signing and not during verification in Cosign. There is also only one signing backend, GCP CA Service, that wouldn’t support embedding SCTs.

I’d recommend we just drop support for verifying detached SCTs during signing in Cosign rather than add support here. Most (all?) other clients don’t support them either.

@cmurphy
Copy link
Contributor Author

cmurphy commented Oct 18, 2024

Fair enough.

@cmurphy cmurphy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants