-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin interface for out-of-tree KMS providers #1658
Add plugin interface for out-of-tree KMS providers #1658
Comments
Two other possible approaches:
|
Given lack of portability this is probably a non-starter
this seems to be based on a convention of a separate binary being named |
Hey Team - how close or far away are we from some sort decision on this and can we be of any help here? |
The go-plugin library seems like the most promising solution. We haven't started working on this yet. Are you interested in implementing it? |
No promises, but I am talking to my dev team to potentially build it. I will get back to you when I have more info. Update: Not sure we will be able to get to this as our team is quite busy. |
@haydentherapper @bobcallaway any chance you and the team of contributors are going to get to this at some point? Unfortunately, we don't have the time. |
Yes, we're planning to take a look at this shortly. |
Just another follow up on this one. Hope it's coming soon, and thanks so much for all your hard work 🙏 |
To update, we've started to take a look and experiment with this. |
Draft PR and spec Link here. #1901 |
Description
Investigate using go-plugin as an approach for out-of-tree KMS providers to integrate with Sigstore tooling without merging code into this repo.
I believe this is the correct interface to base the plugin design off of:
sigstore/pkg/signature/kms/kms.go
Line 72 in 8a49902
The text was updated successfully, but these errors were encountered: