fixedTopPageID Public API has gaps

[mfendeksilverstripe]

Module version(s) affected

5.2.4

Description

Found some public API gaps in DNADesign\Elemental\TopPage\DataExtension related to the fixedTopPageID feature.

The only public API that is available related to this is withFixedTopPage() which is fine as this covers the majority case but we should also have public API for the following methods:

• getFixedTopPageID() - currently exists, but is protected
• setFixedTopPageID() - method is missing

These two methods are needed to properly integrate this feature with other features that use the onBeforeAction and onAfterAction pattern such as copyToLocale.

How to reproduce

Search for the following methods in DNADesign\Elemental\TopPage\DataExtension:

Expected

• getFixedTopPageID() - method is public
• setFixedTopPageID() - method is public

Actual

• getFixedTopPageID() - currently exists, but is protected
• setFixedTopPageID() - method is missing

Possible Solution

Ideally:

• getFixedTopPageID() - change method to public
• setFixedTopPageID() - add this method as public

less ideally but also workable:

• change fixedTopPageID to protected

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)