Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseElement::First() / Last() should be IsFirst() and IsLast() #1274

Open
4 tasks done
kinglozzer opened this issue Nov 12, 2024 · 0 comments
Open
4 tasks done

BaseElement::First() / Last() should be IsFirst() and IsLast() #1274

kinglozzer opened this issue Nov 12, 2024 · 0 comments
Assignees
@GuySartorelli
Labels
type/enhancement

Comments

@kinglozzer
Copy link
Member

kinglozzer commented Nov 12, 2024 •
edited by GuySartorelli
Loading

Description

SS5 replaced $First and $Last with $IsFirst and $IsLast, but this change wasn’t reflected in elemental

Additional context or points of discussion

No response

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs
kinglozzer added a commit to bigfork/silverstripe-elemental that referenced this issue Nov 12, 2024
@kinglozzer
Add IsFirst/IsLast methods to match SS5 conventions (closes silverstr…
01173bf 
…ipe#1274)
@kinglozzer kinglozzer mentioned this issue Nov 12, 2024
Open
8 tasks
kinglozzer added a commit to bigfork/silverstripe-elemental that referenced this issue Nov 12, 2024
@kinglozzer
Add IsFirst/IsLast methods to match SS5 conventions (closes silverstr…
8419585 
…ipe#1274)
@GuySartorelli GuySartorelli self-assigned this Nov 14, 2024
kinglozzer added a commit to bigfork/silverstripe-elemental that referenced this issue Nov 15, 2024
@kinglozzer
NEW: Add IsFirst/IsLast methods to match SS5 conventions (closes silv…
b670501 
…erstripe#1274)
@kinglozzer kinglozzer mentioned this issue Nov 15, 2024
Open
7 tasks
kinglozzer added a commit to bigfork/silverstripe-elemental that referenced this issue Nov 15, 2024
@kinglozzer
NEW: Add IsFirst/IsLast methods to match SS5 conventions (closes silv…
ac1f803 
…erstripe#1274)
kinglozzer added a commit to bigfork/silverstripe-elemental that referenced this issue Nov 15, 2024
@kinglozzer
NEW: Add IsFirst/IsLast methods to match SS5 conventions (closes silv…
fb1eba2 
…erstripe#1274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kinglozzer @GuySartorelli