Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups with access to single subsite can create draft pages on other subsites #434

Open
ornatipinnis opened this issue Jul 2, 2019 · 7 comments

Comments

@ornatipinnis
Copy link

This seems to be an issue that I cannot resolve through the Groups and Roles interface and seems to be a bug with how Subsites works.

I have a basic site (SS4.4) running subsites with the following:

main site

  • subsite: Hutt
  • subsite: Wellington

I create a group called Wellington and one called Hutt within each subsite and provide them both with the following permissions:

  • Access to 'Pages' section
  • Access to 'Files' section

I then set the permissions on Wellington and Hutt so that they can only access a certain subsite (Wellington group can only access Wellington Subsite etc)

I then visit the Wellington sites URL and log in as the Hutt Member and I can view the admin section of the site with the following section options:

  • Pages
  • Files

I can click into Pages and view the sitetree for a site that I shouldn't be able to access. I can also use the Add new button and add draft pages to the site that the user should not be able to access.

If I set the permissions for a group to only be able to access a single sub site then I wouldn't expect that user to be able to view the sitetree or add draft pages to a sitetree on another subsite.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 8, 2019

Almost certainly the same problem as reported here: #358

@ornatipinnis
Copy link
Author

Almost certainly the same problem as reported here: #358

This issue didn't involve sub-groups or roles

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 8, 2019

Yeah - but the problem uncovered in that issue highlighted some pretty major flaws in how subsites handles permission validation.

@ornatipinnis
Copy link
Author

Yeah - but the problem uncovered in that issue highlighted some pretty major flaws in how subsites handles permission validation.

Thanks for the update. Any idea if/when this will be looked at? This is a little bit concerning, especially as this is offered on the CWP platform.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 8, 2019

It has been looked at in the past but is a pretty nuanced problem (see #388). I'm not sure when it will be looked at again. I understand that it's part of the CWP product but we have over 90 modules that we support as part of CWP so it can be difficult.

@ornatipinnis
Copy link
Author

It has been looked at in the past but is a pretty nuanced problem (see #388). I'm not sure when it will be looked at again. I understand that it's part of the CWP product but we have over 90 modules that we support as part of CWP so it can be difficult.

Maybe you should reduce the number of modules offered if you do not have the capacity to support them.

@NightJar
Copy link
Contributor

NightJar commented Jul 8, 2019

Thank you for the report.
This is an open source module, and if you feel you have the ability to contribute, we would welcome the help and provide guidance if necessary.

If you are unable to assist, then this is a question not of capacity, but of priority.
I'm sure given the severity of this issue that the priority will be increased, however time-frames are not something we can comment on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants