Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed login attemps should return a 401 error code instead of 200. #2287

Open
1 task done
samthesamman opened this issue Oct 23, 2024 · 0 comments
Open
1 task done

Comments

@samthesamman
Copy link

Please note that this is only for bug report.

For help on your account, please reach out to us at hi[at]simplelogin.io. Please make sure to check out our FAQ that contains frequently asked questions.

For feature request, you can use our forum.

For self-hosted question/issue, please ask in self-hosted forum

Prerequisites

  • I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

Describe the bug
When a user fails to login with invalid credentials, the app returns a 200 response (with error message shown in UI)

Expected behavior
Some non-2xx response should be returned.

Screenshots
N/A

Environment (If applicable):
N/A

Additional context
For tools like Fail2ban and crowdsec to work, and to help mitigate attacks against self-hosted instances, you should return a proper error code for failed login attempts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant