Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/feature request(windows): console output #87

Open
Kristinita opened this issue Jan 23, 2024 · 0 comments
Open

bug/feature request(windows): console output #87

Kristinita opened this issue Jan 23, 2024 · 0 comments

Comments

@Kristinita
Copy link

1. Summary

It would be nice if Windows users would receive console output as Linux users.

2. MCVE

2.1. AppVeyor

I reproduced the problem from this issue on AppVeyor CI. See the AppVeyor build.

2.2. Commands

# [INFO] Install fkill-cli and simply static server “http-server”:
# https://www.npmjs.com/package/http-server
npm install --global fkill-cli http-server

# [INFO] Run http-server as background process on Windows:
# https://stackoverflow.com/a/39175056/5951529
#
# [INFO] Or manually open the second command prompt,
# print command for running http-server “http-server --port 4147”
# and press “Enter”:
powershell -Command "Start-Process cmd -ArgumentList '/c http-server --port 4147'"

# [INFO] Kill http-server running on port 4147
fkill :4147 --force --verbose

2.3. Behavior

2.3.1. Desired — Ubuntu

On Ubuntu, fkill prints information about the killed process to the console. See Travis build:

$ fkill :4147 --force --verbose

/home/travis/.travis/functions: line 109:  5612 Killed                  http-server --port 4147
2.3.2. Non-desired — Windows

On Windows, fkill doesn’t print to the console any information about the killed process. See AppVeyor build:

fkill :4147 --force --verbose

3. Reason why the feature is needed

It would be nice if Windows users received an informational message whether the fkill command completed successfully or not. Currently, without console output Windows users don’t understand whether the process is killed or not.

4. Environment

  1. Operating system:

    1. Local — Windows 11 10.0.22621.2861
    2. AppVeyor — Windows Server 2019
  2. Node.js

    1. Local — 21.6.0
    2. AppVeyor — 21.2.0
  3. fkill-cli 8.0.0

  4. http-server 14.1.1

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant