Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations #21

Open
jimmyff opened this issue Oct 22, 2019 · 6 comments
Open

Optimisations #21

jimmyff opened this issue Oct 22, 2019 · 6 comments

Comments

@jimmyff
Copy link

jimmyff commented Oct 22, 2019

Hey, this is a great package however it regularly crashes my development enviroment and also sometimes crashed on my pixel 3 device. I think it's because it's applying each filter to the full sized image every time. I notice in your example you resize the image to 600 however i need a higher quality version for my app.

Could it generate thumbnails using a much smaller version of the source image and then when the user selects a filter apply that one on the full sized image? I think it would make the whole thing much more stable and feel more responsive.

@skkallayath
Copy link
Owner

@jimmyff Thanks for the suggestion,

I am planning to implement the same in the very next release. If you already worked out something, please send a PR.

Thanks

@Nemesis19
Copy link

hello...any update on this? thanks

@vermavashish
Copy link

@Nemesis19 Did you find anything on this?

@Mangielijah
Copy link

I Found the issue with the code, its due to spawning multiple isolate using the compute function but not all the isolates get killed
when you are done using the filter

@skkallayath
Copy link
Owner

skkallayath commented Jul 25, 2020

@Mangielijah Thanks for finding out the issue. From the comments of the other issue, I assume you fixed it by creating a worker for the compute operation and kill it later. It will be very helpful if you can create a pull request with the changes.

@Shiba-Kar
Copy link

Eagerly waiting for this to be fixed!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants