From e5ebe5709e8a0c554841db320d0ede58a3cdb0a9 Mon Sep 17 00:00:00 2001 From: bartoval Date: Mon, 8 Jan 2024 07:49:42 +0100 Subject: [PATCH] refactor(Process): :recycle: Make details title optional --- src/pages/Processes/__tests__/Details.spec.tsx | 8 +------- src/pages/Processes/components/Details.tsx | 10 ++++++---- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/pages/Processes/__tests__/Details.spec.tsx b/src/pages/Processes/__tests__/Details.spec.tsx index ddd734c0..9c24f98f 100644 --- a/src/pages/Processes/__tests__/Details.spec.tsx +++ b/src/pages/Processes/__tests__/Details.spec.tsx @@ -1,12 +1,10 @@ import { Suspense } from 'react'; -import { render, screen, waitForElementToBeRemoved } from '@testing-library/react'; +import { render, screen } from '@testing-library/react'; import { Server } from 'miragejs'; import * as router from 'react-router'; import { ProcessResponse } from '@API/REST.interfaces'; -import { waitForElementToBeRemovedTimeout } from '@config/config'; -import { getTestsIds } from '@config/testIds'; import { Wrapper } from '@core/components/Wrapper'; import processesData from '@mocks/data/PROCESSES.json'; import { loadMockServer } from '@mocks/server'; @@ -39,10 +37,6 @@ describe('Process component', () => { }); it('should render the title, description data and processes associated the data loading is complete', async () => { - await waitForElementToBeRemoved(() => screen.queryByTestId(getTestsIds.loadingView()), { - timeout: waitForElementToBeRemovedTimeout - }); - expect(screen.getByText(processResult.parentName)).toHaveTextContent('site 1'); expect(screen.getByText(processResult.groupName)).toHaveTextContent('payment'); expect(screen.getByText(processResult.hostName)).toHaveTextContent('10.242.0.5'); diff --git a/src/pages/Processes/components/Details.tsx b/src/pages/Processes/components/Details.tsx index 45aa9c1f..909af4f4 100644 --- a/src/pages/Processes/components/Details.tsx +++ b/src/pages/Processes/components/Details.tsx @@ -29,7 +29,7 @@ import { SitesRoutesPaths } from '@pages/Sites/Sites.enum'; import { ProcessesLabels, QueriesProcesses } from '../Processes.enum'; import { DetailsProps } from '../Processes.interfaces'; -const Details: FC = function ({ process, title = ProcessesLabels.Details }) { +const Details: FC = function ({ process, title }) { const { identity: processId, parent, @@ -50,9 +50,11 @@ const Details: FC = function ({ process, title = ProcessesLabels.D return ( - - {title} - + {title && ( + + {title} + + )}