Declarative documentation missing deployment configs on YAML

[hash-d]

https://skupper.io/docs/declarative/index.html#skupper-annotations

Since 1.4.1, deployment configs are also supported by Skupper, and need to be allowed on the skupper-site-controller ClusterRole for it to work correctly, otherwise we get the following error:

2023/11/06 17:52:40 Initialising skupper site ...
2023/11/06 17:52:42 Error initialising skupper:  roles.rbac.authorization.k8s.io "skupper-service-controller" is forbidden: user "system:serviceaccount:skupper-site-controller:skupper-site-controller" (groups=["system:serviceaccounts" "system:serviceaccounts:skupper-site-controller" "system:authenticated"]) is attempting to grant RBAC permissions not currently held:
{APIGroups:["apps.openshift.io"], Resources:["deploymentconfigs"], Verbs:["get" "list" "watch"]}

And the service controller deployment does not get created.

See

• Adjusting permissions needed by site controller skupper#1065
• Deployment configs in RBAC role for site controller skupper#1067