Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Animated transition from .long to .short #189

Open
5 tasks done
alikenski opened this issue Oct 5, 2022 · 2 comments
Open
5 tasks done

Not Animated transition from .long to .short #189

alikenski opened this issue Oct 5, 2022 · 2 comments

Comments

@alikenski
Copy link

alikenski commented Oct 5, 2022

Description

The height of .longForm is ~570 and .shortForm height is ~450. And when I call

panModalSetNeedsLayoutUpdate()
panModalTransition(to: state)

code animation is sharp and fast (without transition, not smooth)

What type of issue is this? (place an x in one of the [ ])

  • bug
  • question

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

PanModal version: 1.2.7

iOS version: 14.3 (Simulator)

@kaitoshadow
Copy link

Do you have any solution?

@alikenski
Copy link
Author

@kaitoshadow Yes bro, you should add parameter to protocol extension

extension ViewController: PanModalPresentable {
    ....
    var anchorModalToLongForm: Bool {
        false
    }
    ....
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants