Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from "syscall" to "golang.org/x/sys/unix" #73

Open
3 tasks done
bored-engineer opened this issue Apr 17, 2020 · 0 comments · May be fixed by #74
Open
3 tasks done

Migrate from "syscall" to "golang.org/x/sys/unix" #73

bored-engineer opened this issue Apr 17, 2020 · 0 comments · May be fixed by #74

Comments

@bored-engineer
Copy link
Contributor

bored-engineer commented Apr 17, 2020

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

This is more of a best practice as I'm not aware of any specific issues caused by the older dep.

As of today go-audit uses the "syscall" package which has been frozen since Go 1.4:

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

go-audit should migrate to using golang.org/x/sys/unix instead as new fixes/features are implemented there.

This should be a pretty straightforward migration as most structures are the same in both packages, any concerns with me sending over a pull request for this?

@bored-engineer bored-engineer linked a pull request Apr 18, 2020 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant