Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make boringcrypto: add checklinkname flag for go1.23 #1197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make boringcrypto: add checklinkname flag for go1.23 #1197

wants to merge 1 commit into from

Commits on Aug 13, 2024

  1. make boringcrypto: add checklinkname flag for go1.23 

    Starting with go1.23, we need to set -checklinkname=0 when building for
boringcrypto because we need to use go:linkname to access `newGCMTLS`.

Note that this does break builds when using a go version less than
go1.23.0. We can probably assume that someone using this Makefile and
manually building is using the latest release of Go though.

See:

- https://go.dev/doc/go1.23#linker
    @wadey
    wadey committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9c6fb08 View commit details
    Browse the repository at this point in the history