Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by quality (resolution) #28

Open
sleeyax opened this issue Aug 3, 2024 · 8 comments
Open

Filter by quality (resolution) #28

sleeyax opened this issue Aug 3, 2024 · 8 comments
Labels
feature New feature

Comments

@sleeyax
Copy link
Owner

sleeyax commented Aug 3, 2024

There should be a configurable setting to control which qualities are shown in the stream results. See torrentio for reference.

@mikmc25
Copy link
Collaborator

mikmc25 commented Sep 13, 2024

this can be achieved with regex yes but not the logic that torrentio uses. torrentio has been in development considerably longer so perhaps in a future rev

@cmootdls
Copy link

cmootdls commented Nov 24, 2024

@mikmc25 Correct me if I am wrong but would it not be trivial to filter by resolution with the API response from easynews? From inspecting a curl request to their 2.0 API, it includes resolution in the response."height":"2160","width":"3840"

Unfortunately with 2.0 resolutions can't be filtered (well they can actually, but the max quality of 10 is 1080p, it is quite an old API.

Alternatively their 3.0 API could be used, unfortunately it returns HTML but with a blob of JSON contained. Here is an example request for their 3.0 if you want to give it a go (placeholders included as {}). This API allows filtering by resolution

curl 'https://members.easynews.com/3.0/search?gps={MOVIE_NAME}&sbj=&fil=&fex=&from=&ns=&ac=&vc=&sS=0&s1d=Dec&s1=rel&s2d=&s3d=&d1t=&d2t=&b1t=&b2t=&px1t=3840x2160&px1=3840x2160&px2t=7860x4320&px2=7860x4320&fps1t=&fps2t=&bps1t=&bps2t=&hz1t=&hz2t=&rn1t=&rn2t='  \
  -H "Authorization: Basic BASE64_ENCODED_USERNAME:PASSWORD

Also happy to work on a pull request if you are accepting contributors.

@sleeyax
Copy link
Owner Author

sleeyax commented Nov 24, 2024

Alternatively their 3.0 API could be used, unfortunately it returns HTML but with a blob of JSON contained.

IMO we should stick to v2 as long as possible, as going fully V3 comes with its own set of challenges and I would rather not mix V2 with V3.

Also happy to work on a pull request if you are accepting contributors.

Definitely, we are short on contributors. Much appreciated.

@cmootdls
Copy link

cmootdls commented Nov 24, 2024

@sleeyax Good news, found by accident when you paginate in the web view, it makes pagination requests with /api/ in the path, and this can be used for the initial request, so there is a full RESTful API that can be utilized.

Any ideas why V3 couldn't be used fully compared to V2?

Feel free to try:

curl 'https://members.easynews.com/3.0/api/search?gps=deadpool&px1t=1920x1080&fty[]=VIDEO&u=1&pno=1&dni=100&s1=rel&s1d=Dec'   \
  -H "Authorization: Basic BASE64_ENCODED_USERNAME:PASSWORD"

I'm speaking from a point of total ignorance here, just curious. If you think 2.0 should still be used, am happy to give filtering a go.

@sleeyax
Copy link
Owner Author

sleeyax commented Nov 24, 2024

Thing is when I tried v3 at the very beginning when they launched it the basic auth no longer worked and required cookie authentication instead 😐

Maybe (hopefully) that changed by now then.

@cmootdls
Copy link

Doesn't need cookie auth afaik - just encode your username:password pair with base64 and put it into the request above.

@sleeyax
Copy link
Owner Author

sleeyax commented Nov 24, 2024

In that case go ahead :)

@cmootdls
Copy link

Some quick notes: Torrentio regex patterns should work the same way - they just filter filename by strings according to user configured qualities.
https://github.com/TheBeastLT/torrentio-scraper/blob/061f6f45e0bb5a37c1b1d0cf9e3dfd427e5635fd/addon/lib/filter.js#L105-L221

We can filter the post titles with these keywords and allow them to be configurable by the user.

Will start working on a branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants