-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for (some) Springdoc annotations in the openapi spring module #1819
Comments
This makes sense to me. Probably best to isolate it to the Spring module. |
@mrickly are you keen to do a PR for this ? |
@phillip-kruger : We are open to giving it a try. But we will need some guidance, e.g. the correct location/package for such a change. We would probably start with the ParameterObject and if it works as expected add things as the need arises. |
Ok No worries. Most of the work is done in core (https://github.com/smallrye/smallrye-open-api/tree/main/core) and core then calls out to one of jax-rs, spring or vertx. So this should be done somewhere in spring module (https://github.com/smallrye/smallrye-open-api/tree/main/extension-spring). We just need to see if the "hooks" exist in core. I would assume it will work the same way as smallrye-open-api/extension-jaxrs/src/main/java/io/smallrye/openapi/jaxrs/JaxRsParameter.java Line 25 in e47033d
|
This will likely be in the SpringParameterProcessor. I'm not entirely sure if |
i posted PR #1823 for @mrickly . this would solve our needs. situation is somehow "shady" as quarkus does not seem to behave exactly as spring needing @QueryParam on fields while spring does not. thanks for your review. tell us if you need more tests whatever |
See quarkusio/quarkus#40328
/cc @mrickly
@MikeEdgar - w.d.y.t ?
The text was updated successfully, but these errors were encountered: