Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect calendar entries over multiple days on start_date filter #67

Open
donni106 opened this issue Sep 14, 2022 · 3 comments · May be fixed by #69
Open

Respect calendar entries over multiple days on start_date filter #67

donni106 opened this issue Sep 14, 2022 · 3 comments · May be fixed by #69
Assignees
@gaurav-handysolver
Labels
api Issues to update existing endpoints or to add new ones calendar Adjustments of the HumHub calendar entries
Milestone
0.6

Comments

@donni106
Copy link
Member

As a follow up for #57 can you please respect a given start date filter for events over multiple days?
An example:

  • event starts on 20th of July
  • event ends on 27th of July
  • start_date filter is 22th of July

Currently filtering for start_date on 22th of July that event would not be found. But as this event is still running until 27th of July it should be listed on 22th of July.
@donni106 donni106 added api Issues to update existing endpoints or to add new ones calendar Adjustments of the HumHub calendar entries labels Sep 14, 2022
@donni106 donni106 added this to the 0.6 milestone Sep 14, 2022
@gaurav-handysolver
Copy link
Collaborator

Hi @donni106
The example you give is for a recurring event, if an event starts on 20 and ends on 27 then it is a recurring event and you will get the event detail of 22 July in recurring APIs

@donni106
Copy link
Member Author

No it is not recurring, it is one event over multiple days. Recurring would mean multiple events over multiple days.
It is not a recurring event on every day i am talking about but one event starting on one day, which takes a few days, you know. I think this need to be handled differently?

@gaurav-handysolver
Copy link
Collaborator

Okay got it!

gaurav-handysolver added a commit that referenced this issue Sep 15, 2022
@gaurav-handysolver
Respect calendar entries over multiple days on start_date filter #67
209f0b5 
Now, you will get the event if it is lies in start_date and end_date

For Example: An event is created on 15th sept. and end on 22nd sept. then if you will be fetching the event by passing start_date=2022-09-18 then the event will be getting, because it is lies in the date range
@gaurav-handysolver gaurav-handysolver linked a pull request Sep 15, 2022 that will close this issue
Open
@donni106 donni106 linked a pull request Sep 15, 2022 that will close this issue
Respect calendar entries over multiple days on start_date filter #67 #69
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurav-handysolver gaurav-handysolver

Labels
api Issues to update existing endpoints or to add new ones calendar Adjustments of the HumHub calendar entries
Projects
None yet
Milestone
0.6
2 participants
@donni106 @gaurav-handysolver