timelock: tests the operation store dump #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbac
suggested changes
Feb 6, 2024
|
|
||
| w.Flush() | ||
| } | ||
| } | ||
|
|
||
| // writeOperationStore writes the operations to the writer. | ||
| func writeOperationStore( |
There was a problem hiding this comment.
nit: Now that you extracted the writeOperationStore I think it makes sense for the timelock-worker store to be independent from the timelock-worker itself, so the tw interacts with it via an interface. This is quite a heavy work, so no need to address it here, I'll create an issue.
There was a problem hiding this comment.
Agreed.. I wanted to stop short of that while increasing some test coverage. I think the TODO above would be handled in such an effort to extract the store.
Tests that dumping the operation store actually writes the expected values to file. Injects a time faker function and refactors dumpOperationStore to improve testability.
MStreet3
force-pushed
the
feat/scheduler-tests
branch
from
f6928c4
to
a47654c
Compare
fbac
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that dumping the operation store actually writes the expected values to file. Injects a time faker function and refactors dumpOperationStore to improve testability.