Feat/add prometheus #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a prometheus metrics server on a default port.
MStreet3
commented
Feb 15, 2024
| # i.e. If the file is located in the project root, then the value of ENV_FILE | ||
| # should be "timelock.env". If the file is located in a subdirectory, then the | ||
| # value of ENV_FILE should be "subdirectory/timelock.env". | ||
| ENV_FILE="timelock.env" |
There was a problem hiding this comment.
used in the docker compose file to specify the source config file that will be mounted in the container at /app/timelock.env
fbac
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for prometheus instrumentation to the worker. No metrics are added but the default Go client metrics are now served on port 2120. A docker compose project is added with a README for running the service locally with a prometheus scraper instance running optionally.
Testing
The image below shows the number of go-routines active while the worker is running. There is no increasing trend.
This image was generated by running the timelock worker and prometheus instance and navigating to the prometheus instance to view the metric graphs.