-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out mf2 h-feed authorship #195
Comments
thanks for filing! granary currently uses the authorship algorithm to find the feed author, but that's evidently for posts, not feeds. so i guess you're right, maybe i should use the h-feed's p-author mf2 property first, and if not provided, fall back to representative h-card. |
lots more discussion on this recently on #indieweb-dev and on #microformats, but no conclusion. basically, we don't yet have an "authoritative" way to determine an h-feed's author, at least if it doesn't have an explicit @tantek's comments here are perhaps the closest thing to a conclusion: basically, we still need to do some research and come up with an algorithm. we don't necessarily have the "right" one just yet.
|
i'm not necessarily going to take on researching and creating this new h-feed authorship algorithm, but i will take two todos here:
|
Here is the algorithm I am using to parse feed author in the wild, quoted from indieweb/authorship/issues/4:
This would at least fix the example feed parsing for this issue, setting the author to be "IndieNews en @ news.indieweb.org/en" |
… feeds for #195. not fully functional yet. ugly.
i've taken a stab at this in 8e190da, but it's an ugly refactoring and nowhere near usable yet, and i don't see a clear path to get it merged. open to other thoughts or attempts! |
Source: HTML
Target: Atom/XML
Example: https://granary.io/url?input=html&output=atom&url=https://news.indieweb.org/en
Expected feed author: IndieNews en @ https://news.indieweb.org/en
Actual feed author: The first h-card on the page
Note: The feed id and title is correct, but the
<author>
element is not.Suggested solution: Granary should follow the representative-h-card-parsing algorithm, and if no h-card is found then use
<title>
and page URL as the author, instead of incorrectly assuming the first h-card is the page's author.The text was updated successfully, but these errors were encountered: