-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluesky.from_as1: convert links, @-mentions, and hashtags to facets #675
Comments
Possibly not the place for this(?) but we also need to think about link cards on Bluesky as those aren't implicitly created like they are on e.g. Mastodon. Should it be the first or last link in a post, by default? My gut would be last based on how I usually format posts |
@JoelOtter Ooh good point! Last link sounds fine to me, but I wonder if there's a more native mf2 way to do it. Will ask on #microformats. |
From snarfed/bridgy#1661 (comment) :
|
@JoelOtter we discussed link preview cards briefly on #microformats and ended up with the proposal that users could use |
Makes good sense to me. I think I'd still opt to make it the last one but as long as it's documented and configurable either should be good! |
I guess the other question is do we still include the URL in the post itself or do we remove it in favour of just the link card? Bluesky lets you do this |
Oh sorry, yes, definitely last! Whether to remove the link or not, good question. Maybe yes when it's the very last text in content, and we generate a preview for it, otherwise no? |
...even if it was converted from HTML content. for #675
Got hashtags working! https://bsky.app/profile/snarfed.bsky.social/post/3kp3bfhk25d2c |
I fear this has broken Bluesky publish - it seems to be creating facets for all tags, not just hashtags, which may not be present in the text. Example for this post: |
Oh no! Sorry about that, you're right. Will fix. |
OK @JoelOtter that should be fixed, feel free to try again. |
Works great, thank you!
…On Sat, 6 Apr 2024 at 06:00, Ryan Barrett ***@***.***> wrote:
OK @JoelOtter <https://github.com/JoelOtter> that should be fixed, feel
free to try again.
—
Reply to this email directly, view it on GitHub
<#675 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVDELHYRU2B6ST5XCYQU23Y34GHTAVCNFSM6AAAAABC2LXFLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGYYTQOBVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Got mentions working! https://bsky.app/profile/snarfed.bsky.social/post/3kpgoiehgt32y |
@JoelOtter feel free to try hashtags with |
The one remaining bit here is to convert arbitrary HTML links, ie |
We should support facet output in
from_as1
! Specifically, convert mention and hashtagtag
s toapp.bsky.richtext.facet#mention
s and#tag
s, respectively, and HTML links incontent
to#link
s.This will be a bit tricky, since we don't currently generate indices for those
tag
s in egmicroformats.json_to_object
andSource.postprocess_object
, and we don't generate anything at all for plain links yet. We'd want to look into how AS1 tag indices work anyway, eg do they always index into plain text content, egcontent.value
?cc @JoelOtter
The text was updated successfully, but these errors were encountered: