-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Property not configureable" error on Development when upgrading to V3 #4225
Comments
Repo is pushed to this https://github.com/im-alihashmi14/ReanimatedV3 |
I have the same problem with Reanimated version React Native version Platforms JavaScript runtime Workflow Architecture Build type |
Got same error on react-native 0.66.3 reanimated ^3.0.0 |
Got same error on react-native 0.71.4 reanimated ^3.0.2 |
Got same error on reanimated ^3.0.0 |
Same error goes for me since reanimated v3. In the repro provided, there is a .map().
|
@JB-CHAUVIN If you put keys to the array items then it also gets resolved. It is due to the console.log that trigger the warning |
I've encountered a similar issue with Reanimated V3 where I have to press Ctrl+S every time to start the app. This seems to be a recurring problem and could potentially be a hindrance to the app's overall usability. |
did you correctly do the yarn start --reset-cache after upgrading ? I think I had similar issue and reset-cache fixed it |
I'm on |
Same error here with reanimated > 3.0.0 |
I was able to reproduce my error (not exactly the same, but similar) in a new project as well by calling If I call it from a Both errors appear on iOS only, I don't seem them on Android. Repro: https://github.com/mlazari/ReanimatedRepro/blob/main/App.tsx#L60 |
I was able to repro on Android, so the issue is on both platforms |
On my side issue happened when using require('file'). I have no issue on 3.0.0-rc.10 (tested only on Android) . Can it be linked to babel ? I had a look into diff between these versions, I didn't find anything relevant... |
@fgagneten Yes, with map without key I am able to reproduce the error on both platforms: https://github.com/mlazari/ReanimatedRepro/blob/map-without-key/App.tsx#L78 |
I don't know what would be the solution, but the problem seems to come from this assignment
console non-configurable and thus makes this call to Object.defineProperties in React throw that error - https://github.com/facebook/react/blob/v18.2.0/packages/shared/ConsolePatchingDev.js#L46
|
Can confirm that the issue is from the |
Fixes React bug that tries to modify `console` and can't. closes software-mansion#4225
FYI, I downgraded to |
Same here, just updated to RN 0.74.4 from 0.71.3 |
@marcofuentes05 @wsiddiqui-nisum-com, did you guys ever find a solution? |
On Mon, 25 Nov 2024 at 04:23, ConnorNusser ***@***.***> wrote:
@marcofuentes05 <https://github.com/marcofuentes05> @wsiddiqui-nisum-com
<https://github.com/wsiddiqui-nisum-com>, did you guys ever find a
solution?
—
Reply to this email directly, view it on GitHub
<#4225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2EWNZ5P3M7RB2LXVO7UG32CJ32JAVCNFSM6AAAAABQCOCRJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGQ4TCMJUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
As of me, I didn’t find a solution to this.
|
react-native-reanimated: ^3.0.0-rc.0 When using FlatList. |
@manzoorsofi What is the exact version of react-native-reanimated you are using? "react-native-reanimated: ^3.0.0-rc.0" is not specific enough, you could have the old |
@mlazari i am using react-native-reanimated@3.16.5 |
@mlazari "I'm encountering the same error whenever I use FlatList. Previously, I avoided using FlatList to bypass the issue, but now I've reached a point in the project where I need to integrate GooglePlacesAutocomplete. The problem arises in a component where, as soon as I start typing, the issue occurs." |
@manzoorsofi Ok, I had this error last year but don't have it anymore so I thought maybe you were on an older version. I don't remember what fixed it, but I think it was a react-native-reanimated update. As far as I remember it was related to console warns, so maybe your FlatLists are triggering some warnings. For example I think duplicate keys (2 data items with the same id, or whatever key is keyExtractor prop returning if you are using it) would trigger a warning. |
can you tell me where exactly are these console warns |
@manzoorsofi It's somewhere in the react dependency I guess. It's the message mentioned here: https://stackoverflow.com/questions/56174189/why-is-there-double-with-the-same-key-in-my-react-native-flatlist (search for "Encountered two children with the same key" in node_modules) and it could be a console.warn(...) or a console.error(...), I don't remember exactly. Commenting it out would be just a way to test if that's the cause though and not a reliable solution, since there could be many other places in the code / other dependencies that call console.warn / console.error. |
@manzoorsofi I found where this was fixed - #4252 (comment) |
@mlazari ok was it working in version v3.1.0 ???? |
@manzoorsofi Yes, 3.1.0 fixed this issue for me and it's still working in the latest 3.16.5 for me (but I am using the latest react-native too, 0.76.5, with new architecture turned off). |
@ConnorNusser @mlazari @manzoorsofi @reanzi @marcofuentes05 Code Example: {data.map((item, index) => renderListItem(item, index !== (data.length - 1)))}
}; so it exactly looks and behaves like Flatlist. Hope it helps. |
@manzoorsofi I just saw the issue you opened in React Native, but that repro repository you posted doesn't seem to be public, it's giving me a 404 error. |
@mlazari @wsiddiqui-nisum-com |
@manzoorsofi I took a look and it seems to be related to react-native-svg-transformer This change in Not sure why though, since your project doesn't seem to use expo modules as far as I can tell, so it should work without selecting react-native explicitly. This is not the same issue as this react-native-reanimated issue, which was resolved in version 3.1.0. |
@manzoorsofi It's probably something in your local environment, I don't see it on my side and I tried both iOS and Android. Maybe you need to clear some cache and / or rebuild the app or something. The only thing I see is this warning which seems to come from native-base (GeekyAnts/NativeBase#5758): |
@mlazari
|
@manzoorsofi Did you update your |
No @mlazari `const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config'); /**
const config = { module.exports = mergeConfig(getDefaultConfig(__dirname), config); ` |
@manzoorsofi Sorry, I am not sure why it's not working for you. I am able to reproduce the issue with |
@mlazari You checked the GooglePlacesAutocomplete in my repo ?? |
@manzoorsofi I don't have the repo on the computer that I use now, but on the other one yes, I think the way I was reproducing was add doctor -> select location or something like that. I even tried deleting all app code in src and just rendering a FlatList and the error was reproducible with |
@manzoorsofi If you can give me read access to the repo I could give it another try on the computer I am using now, to make sure it was not something specific on the other computer. |
@mlazari Sure |
@manzoorsofi You're right, on this computer that change doesn't seem to fix it... |
Damn, what to do ?? |
@manzoorsofi I pushed a change that seems to fix that error in the
|
Description
This issue is only starting to occur after upgrading the current project to V3.
I don't know if it's bugging everyone or not but in all my projects is behaving the same way. I even initialise the new project still same error.
Steps to reproduce
Snack or a link to a repository
https://github.com/im-alihashmi14/ReanimatedV3
Reanimated version
3.0.1
React Native version
0.66.4
Platforms
Android, iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
Real device
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: