Debug dump utility dash objects update #19440
Conversation
|
@Pterosaur Please review |
|
/azpw run Azure.buildimage |
|
/AzurePipelines run Azure.buildimage |
|
No pipelines are associated with this pull request. |
|
Commenter does not have sufficient privileges for PR 19440 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -1128,6 +1128,10 @@ SONIC_PLATFORM_PY3_WHEEL_NAME=$(basename {{platform_api_py3_wheel_path}}) | |||
| sudo cp {{platform_api_py3_wheel_path}} $FILESYSTEM_ROOT/$SONIC_PLATFORM_PY3_WHEEL_NAME | |||
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install $SONIC_PLATFORM_PY3_WHEEL_NAME | |||
| sudo rm -rf $FILESYSTEM_ROOT/$SONIC_PLATFORM_PY3_WHEEL_NAME | |||
|
|
|||
| sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/libdashapi_*.deb || \ | |||
There was a problem hiding this comment.
If this is sonic-utilities's dependency, you do not need to install it explicitly. #Closed
There was a problem hiding this comment.
Yes it is sonic-utilities dependency, but the libdashapi debian package is not implicitly installed by specifying just the sonic-utilities dependency,
admin@r-ocelot-07:~$ dump state --show
Traceback (most recent call last):
File "/usr/local/bin/dump", line 5, in <module>
from dump.main import dump
File "/usr/local/lib/python3.11/dist-packages/dump/main.py", line 9, in <module>
from dump.match_infra import RedisSource, JsonSource, MatchEngine, CONN
File "/usr/local/lib/python3.11/dist-packages/dump/match_infra.py", line 10, in <module>
from dump.dash_util import get_decoded_value
File "/usr/local/lib/python3.11/dist-packages/dump/dash_util.py", line 6, in <module>
from dash_api.types_pb2 import Guid, IpAddress, IpPrefix
ModuleNotFoundError: No module named 'dash_api'
There was a problem hiding this comment.
Then something is missing to achieve implicitly install of dependency. Could you check why?
There was a problem hiding this comment.
I think the DEBS_DEPENDS packages are not automatically installled in the target image, for example:
In sonic-yang-models-py3.mk the py3 whl is dependent on LIBYANG. But this deb package is also explicitly installed along with the .whl in sonic_debian_extension.j2
There was a problem hiding this comment.
@qiluo-msft Created a new issue as previously discussed (The .deb is not installed automatically when *.whl is installed) #20742 regarding the issue specified
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
Why I did it
This PR is required for the changes in sonic-net/sonic-utilities#3387. Adds
libdashapiin the image and adds dependency oflibdashapitosonic-utilitiesWork item tracking
How I did it
Changed
files/build_templates/sonic_debian_extension.j2to installlibdashapito the image and changedrules/sonic-utilities.mkto add the dependencyHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)