Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRR]Setting multipath size to 512 and disabling bgp-vnc for optimization #20744

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −0
Open

[FRR]Setting multipath size to 512 and disabling bgp-vnc for optimization #20744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524e39b
[FRR]Setting multipath size to 512 and disabling bgp-vnc for optimiza…
dgsudharsan Nov 8, 2024
f52dc6a
Merge remote-tracking branch 'upstream/master' into frr_scale_patches
dgsudharsan Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/sonic-frr/patch/0054-Updating-rules-to-set-multipath-to-512-and-removing-.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
From ca51d39440db46e766a81987f407ef794d697876 Mon Sep 17 00:00:00 2001
From: dgsudharsan <sudharsand@nvidia.com>
Date: Fri, 8 Nov 2024 22:14:31 +0000
Subject: [PATCH] Updating rules to set multipath to 512 and removing bgp vnc


diff --git a/debian/rules b/debian/rules
index aa13106fec..e280b6c45b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -68,8 +68,7 @@ override_dh_auto_configure:
--disable-protobuf \
--disable-zeromq \
--enable-ospfapi \
- --enable-bgp-vnc \
- --enable-multipath=256 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use case to have 512 ECMP paths from FRR.

Currently FRR uses uint8 for num paths.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed by FRR FRRouting/frr#16967. We will be taking this fix once FRR upgrade is done. We do have some specific use case scenarios where the number of nexthops might scale more than 256. So we are setting to 512 here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer to the topology here sonic-net/sonic-mgmt#15355

+ --enable-multipath=512 \
\
--enable-user=frr \
--enable-group=frr \
--
2.43.2

1 change: 1 addition & 0 deletions src/sonic-frr/patch/series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,4 @@
0053-bgpd-Set-md5-TCP-socket-option-for-outgoing-connections-on-listener.patch
build-dplane-fpm-sonic-module.patch
bgpd-lib-Include-SID-structure-in-seg6local-nexthop.patch
0054-Updating-rules-to-set-multipath-to-512-and-removing-.patch
Loading