Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new LZSS compressors are slow #6

Open
Clownacy opened this issue Mar 16, 2019 · 0 comments
Open

The new LZSS compressors are slow #6

Clownacy opened this issue Mar 16, 2019 · 0 comments

Comments

@Clownacy
Copy link
Member

Until December last year, this library used the "longest run" LZSS compression method, which is naive and does not produce the smallest possible files. I eventually ported my implementation of a graph-based compressor, but immediately this caused a massive performance issue.

While graph-based compressors are indeed more performance- and memory-intensive than longest-run compressors, I don't believe it should be anywhere near this bad: the original implementation I based this library's compressors on performed infinitely better.

I was able to improve the performance a bit by inlining everything and not relying on generic types, but the performance is still terrible enough to make SonLVL hang for about 10 seconds when it saves.

I'm not sure what to do about this besides just ripping out the new compressors entirely (and accept that I have to recompress everything myself after SonLVL bloats my level data), so I'm leaving an issue here to see if anyone has any ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant