Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal point sequence not detected #132

Open
madig opened this issue Apr 18, 2022 · 3 comments
Open

Illegal point sequence not detected #132

madig opened this issue Apr 18, 2022 · 3 comments

Comments

@madig
Copy link
Contributor

madig commented Apr 18, 2022

ufolint passes the following glif file:

<?xml version="1.0" encoding="UTF-8"?>
<glyph name="test" format="2">
	<advance width="698"/>
	<outline>
		<contour>
			<point x="453" y="729" type="curve" smooth="yes"/>
			<point x="436" y="729"/>
			<point x="426" y="740"/>
			<point x="426" y="759" type="curve" smooth="yes"/>
			<point x="426" y="784"/>
			<point x="444" y="805"/>
			<point x="466" y="805" type="line" smooth="yes"/>
			<point x="483" y="805"/>
			<point x="493" y="794"/>
			<point x="493" y="775" type="curve" smooth="yes"/>
			<point x="493" y="750"/>
			<point x="475" y="729"/>
		</contour>
	</outline>
</glyph>

Note the type="line" that should be a curve. Loading the source with glifLib throws an error however.

@chrissimpkins
Copy link
Member

Something appropriate upstream and exception caught here?

@madig
Copy link
Contributor Author

madig commented Apr 19, 2022

Well upstream catches it on glif load but ufolint doesn't 🤔

@chrissimpkins
Copy link
Member

That is either a bug here or something new that hasn't made it into the defined dependency versions. We should be catching everything that raises on UFO reads with validation toggled on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants