Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cardinality for element in SpdxDocument and Bom classes #841

Closed
goneall opened this issue Aug 11, 2024 · 4 comments · Fixed by #845
Closed

Change cardinality for element in SpdxDocument and Bom classes #841

goneall opened this issue Aug 11, 2024 · 4 comments · Fixed by #845
Assignees
Milestone

Comments

@goneall
Copy link
Member

goneall commented Aug 11, 2024

From the SPDX tech call 30 July 2024, we reached consensus that the SpdxDocument and Bom classees should have a minimum of 1 element.

We should update the model to reflect this decision.

@goneall goneall added this to the 3.0.1 milestone Aug 11, 2024
@goneall
Copy link
Member Author

goneall commented Aug 11, 2024

@zvr - How do we override the superclass restrictions to change the cardinality in the markdown files?

@goneall
Copy link
Member Author

goneall commented Aug 11, 2024

@zvr if it's easy, could you create the PR for the cardinality changes? Otherwise, I can do it early Monday - hoping to get this in before the OMG deadline.

@zvr
Copy link
Member

zvr commented Aug 12, 2024

Just to verify:

  • can be empty:
    • /Core/ElementCollection
    • /Core/Bundle
  • must have at least one element
    • /Core/SpdxDocument
    • /Core/Bom
    • /Software/Sbom (inherits from /Core/Bom)

Must these also have at least one rootElement ?

@zvr
Copy link
Member

zvr commented Aug 12, 2024

OK, to save us time, I created two PRs, depending on what we need to be non-empty:

We should merge only one of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants