Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reporting to WBM and WC methods #453

Closed
Yuval-Ariel opened this issue Mar 27, 2023 · 2 comments · Fixed by #556
Closed

Add reporting to WBM and WC methods #453

Yuval-Ariel opened this issue Mar 27, 2023 · 2 comments · Fixed by #556
Assignees
@Yuval-Ariel @erez-speedb
Labels
enhancement New feature or request

Comments

@Yuval-Ariel
Copy link
Contributor

currently, reporting to the LOG through the WBM or WC is unreachable. this is especially complicated since the WBM and WC can be associated with more than 1 DB so theres the question, where should it report?
@Yuval-Ariel Yuval-Ariel added enhancement New feature or request To review A feature request that has not been reviewed yet labels Mar 27, 2023
@Yuval-Ariel Yuval-Ariel self-assigned this Mar 27, 2023
@Yuval-Ariel
Copy link
Contributor Author

i believe we can store all the info_log (from ImmutableDBOptions) in the WBM so that the WBM can report to all the DBs its connected to.
@udi-speedb thoughts?

@Yuval-Ariel Yuval-Ariel removed the To review A feature request that has not been reviewed yet label Jun 12, 2023
@Yuval-Ariel Yuval-Ariel linked a pull request Jun 13, 2023 that will close this issue
Logger: Add reporting capabilities to the WBM #556
Merged
@Yuval-Ariel Yuval-Ariel mentioned this issue Jun 26, 2023
Open
@Yuval-Ariel
Copy link
Contributor Author

@erez-speedb , plz run performance. we expect no degradation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yuval-Ariel Yuval-Ariel

@erez-speedb erez-speedb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logger: Add reporting capabilities to the WBM speedb-io/speedb
2 participants
@Yuval-Ariel @erez-speedb