Enable speedb features rebase #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running make_format on the branch still has formatting issues |
udi-speedb
requested changes
Jun 8, 2023
|
@RoyBenMoshe - An initial batch of comments. Let's discuss |
udi-speedb
reviewed
Jun 8, 2023
udi-speedb
reviewed
Jun 8, 2023
udi-speedb
reviewed
Jun 8, 2023
mrambacher
reviewed
Jun 8, 2023
udi-speedb
requested changes
Jun 11, 2023
|
@RoyBenMoshe Another batch of comments. I am not done yet, but will wait with the rest until you have addressed the comments in this batch. Thanks |
udi-speedb
requested changes
Jun 12, 2023
|
Please update the HISTORY.md as part of the PR as well. |
udi-speedb
requested changes
Jun 13, 2023
include/rocksdb/options.h
Outdated
| // enable the spdb features | ||
| // please note that a call to enable speedb options in the level of cf should | ||
| // follow | ||
| DBOptions* EnableSpeedbFeaturesDB(SpeedbSharedOptions& shared_options); |
There was a problem hiding this comment.
Same as above (the cf part)
mrambacher
previously requested changes
Jun 14, 2023
udi-speedb
reviewed
Jun 14, 2023
udi-speedb
reviewed
Jun 16, 2023
udi-speedb
reviewed
Jun 16, 2023
udi-speedb
approved these changes
Jun 25, 2023
ayulas
approved these changes
Jul 12, 2023
mrambacher
reviewed
Jul 12, 2023
RoyBenMoshe
force-pushed
the
enable_speedb_features_rebase
branch
from
6975047
to
46f8553
Compare
|
on hold until #610 is pushed |
|
This cannot be merged until the requested changes from @mrambacher are addressed. |
ayulas
approved these changes
Jul 24, 2023
RoyBenMoshe
force-pushed
the
enable_speedb_features_rebase
branch
2 times, most recently
from
c941690
to
d6dd77f
Compare
autogit-speedb
force-pushed
the
enable_speedb_features_rebase
branch
from
d6dd77f
to
25ecc10
Compare
autogit-speedb
force-pushed
the
enable_speedb_features_rebase
branch
from
9cdd880
to
1edf41a
Compare
ayulas
reviewed
Aug 7, 2023
| @@ -299,8 +303,6 @@ DEFINE_string( | |||
| "\twaitforcompaction - pause until compaction is (probably) done\n" | |||
| "\tflush - flush the memtable\n" | |||
| "\tstats -- Print DB stats\n" | |||
| "\ttable-readers-mem -- Print table readers memory. excluding memory " | |||
options/options.cc
Outdated
| } | ||
|
|
||
| void SharedOptions::IncreaseWriteBufferSize(size_t increase_by) { | ||
| if (write_buffer_manager->buffer_size() == 1 && increase_by > 1) { | ||
| write_buffer_manager->SetBufferSize(increase_by); | ||
| if (total_ram_size_bytes_ / 4 > increase_by) { |
There was a problem hiding this comment.
using 4 is not the right way . pls defined and. use the define
options/options.cc
Outdated
| } | ||
|
|
||
| void SharedOptions::IncreaseWriteBufferSize(size_t increase_by) { | ||
| if (write_buffer_manager->buffer_size() == 1 && increase_by > 1) { | ||
| write_buffer_manager->SetBufferSize(increase_by); | ||
| if (total_ram_size_bytes_ / 4 > increase_by) { |
There was a problem hiding this comment.
pls calc the increase size on a local parameter, and just call SetBufferSize once with the correct value
autogit-speedb
force-pushed
the
enable_speedb_features_rebase
branch
2 times, most recently
from
57a129b
to
98fbb56
Compare
autogit-speedb
force-pushed
the
enable_speedb_features_rebase
branch
from
98fbb56
to
b4be9d9
Compare
udi-speedb
pushed a commit
that referenced
this pull request
Nov 22, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.