-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
548: Support Spdb memtable in Java and C #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the preferred way of adding code in the plugin directory into Java. This now makes Java dependent on compiling with the Speedb features enabled and requires the code to be managed/merged between RocksDB and Speedb versions.
If the goal is to minimize Speedb changes in the base RocksDB code, then this code should be separated out into its own files/directory under the speedb plugin and added to Java accordingly.
ba75ac9
to
09d6240
Compare
it seems that this PR also make the speedb memtable not a plugin, right? |
09d6240
to
b6b3f8a
Compare
this ticket must be insert after 639-move-spdb-memtable-from-plugin-to-main-code |
For Java, this could have been done via the CreateFromString in the same manner that Filters were exposed. This would have eliminated the need for all of the custom classes and changing the code to a plugin. Is there a reason this approach was not chosen? Something similar could have been implemented in C, but I am not aware of any exposures of CreateFromString in that language as of yet. |
b6b3f8a
to
be6d914
Compare
No description provided.