Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

548: Support Spdb memtable in Java and C #612

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

ayulas
Copy link
Contributor

@ayulas ayulas commented Jul 24, 2023

No description provided.

@Guyme Guyme linked an issue Jul 24, 2023 that may be closed by this pull request
@Guyme Guyme requested a review from RoyBenMoshe July 24, 2023 12:18
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the preferred way of adding code in the plugin directory into Java. This now makes Java dependent on compiling with the Speedb features enabled and requires the code to be managed/merged between RocksDB and Speedb versions.

If the goal is to minimize Speedb changes in the base RocksDB code, then this code should be separated out into its own files/directory under the speedb plugin and added to Java accordingly.

@ayulas ayulas force-pushed the 548-java-spdb-memtable-support branch 5 times, most recently from ba75ac9 to 09d6240 Compare August 14, 2023 12:40
HISTORY.md Outdated Show resolved Hide resolved
@Yuval-Ariel
Copy link
Contributor

it seems that this PR also make the speedb memtable not a plugin, right?
if so then either update the description or better yet, divide into 2 separate PRs

@Guyme Guyme changed the title 548: Support Spdb memtable in Java 548: Support Spdb memtable in Java and C Aug 16, 2023
@ayulas ayulas force-pushed the 548-java-spdb-memtable-support branch from 09d6240 to b6b3f8a Compare August 16, 2023 15:00
@ayulas
Copy link
Contributor Author

ayulas commented Aug 16, 2023

this ticket must be insert after 639-move-spdb-memtable-from-plugin-to-main-code

@mrambacher
Copy link
Contributor

For Java, this could have been done via the CreateFromString in the same manner that Filters were exposed. This would have eliminated the need for all of the custom classes and changing the code to a plugin. Is there a reason this approach was not chosen?

Something similar could have been implemented in C, but I am not aware of any exposures of CreateFromString in that language as of yet.

@ayulas ayulas force-pushed the 548-java-spdb-memtable-support branch from b6b3f8a to be6d914 Compare August 18, 2023 15:38
@Yuval-Ariel Yuval-Ariel merged commit 54bd545 into main Aug 19, 2023
11 checks passed
@Yuval-Ariel Yuval-Ariel deleted the 548-java-spdb-memtable-support branch August 19, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Sorted Hash Memtable supported via Java API?
4 participants