Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py still requires 'setuptools_scm<6.0.0' #144

Open
band-a-prend opened this issue Aug 13, 2022 · 4 comments
Open

setup.py still requires 'setuptools_scm<6.0.0' #144

band-a-prend opened this issue Aug 13, 2022 · 4 comments

Comments

@band-a-prend
Copy link

The file setup.py still has setup_requires=['setuptools_scm<6.0.0']. That results in error on build from source.
Could it be safely updated to actual 7.0.5 version, i.e restricted with 'setuptools_scm<7.1.0' or smth. else?

@joeced
Copy link
Collaborator

joeced commented Aug 14, 2022

Can you provide steps to reproduce this? I.e which Python version, which OS, etc.

@band-a-prend
Copy link
Author

band-a-prend commented Aug 14, 2022

  • Gentoo Linux (source based distributive);
  • setuptools_scm-7.0.5 provided by Gentoo repository (this is the only version presented in it's repo);
  • Python 3.10.

The packages from PyPi repo usually prefered to be installed via system package manager in Gentoo Linux. Therefore I installed setuptools_scm-7.0.5 from Gentoo repository and then teied to build sphinxcontrib-matlabdomain from tarball provided by PyPi project page, i.e. tried to create package of sphinxcontrib-matlabdomain (to build later Cantera library documentation that depends on sphinxcontrib-matlabdomain).

Actualy I could restore old setuptools_scm localy or use it installed ia pip for this purpose. This time I edited the setup.py from sphinxcontrib-matlabdomain last version tarball to allow to be built against setuptoools_scm-7.0.5 and it was built successfully but I'm not sure that it fully compatible. Initially setup.py has restriction of setuptools_scm<6.0.0.

@joeced
Copy link
Collaborator

joeced commented Aug 17, 2022

Thanks for the extra information.

It seems to be Python 3.6 that was the issue, in this branch I removed the setuptools_scm restriction, at the expense of Python 3.6 compatibility.

Can you try to clone and install directly from the repo?

@band-a-prend
Copy link
Author

Sorry for so long delay. I completely forgot to check changes :(
I check the build process from update-setuptools-scm branch and it's successfully configure and compile for python 3.10 + setuptools_scm-7.0.5 + sphinx-5.1.1.

P.S.
There were some tests failures/errors but don't worry: I found similar known problem with export of sphinx.builders.epub3 in other gentoo package during testing via package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants