Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass token_credential to BlockBlobService #3005

Open
bvontimitta opened this issue Oct 7, 2020 · 1 comment · May be fixed by #3008
Open

Pass token_credential to BlockBlobService #3005

bvontimitta opened this issue Oct 7, 2020 · 1 comment · May be fixed by #3008
Labels
wontfix

Comments

@bvontimitta
Copy link

bvontimitta commented Oct 7, 2020 •
edited
Loading

In azureblob.py the token_credential param (optional) is not passed toBlockBlobService.

    @property
    def connection(self):
        return blockblobservice.BlockBlobService(account_name=self.options.get("account_name"),
                                                 account_key=self.options.get("account_key"),
                                                 sas_token=self.options.get("sas_token"),
                                                 protocol=self.kwargs.get("protocol"),
                                                 connection_string=self.kwargs.get("connection_string"),
                                                 endpoint_suffix=self.kwargs.get("endpoint_suffix"),
                                                 custom_domain=self.kwargs.get("custom_domain"),
                                                 is_emulated=self.kwargs.get("is_emulated") or False)

According to the docs it's a valid input param
vbarbaresi added a commit to vbarbaresi/luigi that referenced this issue Oct 12, 2020
@vbarbaresi
upgrade azure-storage to the latest version that supports BlockBlobSe…
b8949d7 
…rvice and fix spotify#3005

azure-storage==0.36 didn't support `token_credential` argument in `BlockBlobService` init.
Upgrade to the new package `azure-storage-blob` and use the last version that still supports `BlockBlobService` (it's deprecated,
but that can be upgraded another time)

Fixes spotify#3005 by passing `token_credential` argument.

I also had to explicitely default the protocol to "https", otherwise the initialization fails when we provide a token_credential argument.
@vbarbaresi vbarbaresi linked a pull request Oct 12, 2020 that will close this issue
Open
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade azure-storage and pass token_credential argument (#3005) vbarbaresi/luigi
1 participant
@bvontimitta